Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: pluggable PD scheduler #1799

Merged
merged 51 commits into from
Dec 18, 2019
Merged

proposal: pluggable PD scheduler #1799

merged 51 commits into from
Dec 18, 2019

Conversation

CheneyDing
Copy link
Contributor

What problem does this PR solve?

#1787

nolouch
nolouch reviewed Oct 12, 2019
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! generally it seems ok, we need more tests for load, unload, update

conf/move_leader_config.toml Outdated Show resolved Hide resolved
server/api/plugin.go Show resolved Hide resolved
server/handler.go Outdated Show resolved Hide resolved
server/coordinator.go Outdated Show resolved Hide resolved
server/coordinator.go Outdated Show resolved Hide resolved
@nolouch nolouch added the component/schedule Scheduling logic. label Oct 12, 2019
rleungx
rleungx reviewed Oct 14, 2019
View reviewed changes
tools/pd-ctl/pdctl/command/plugin_command.go Outdated Show resolved Hide resolved
tools/pd-ctl/pdctl/command/plugin_command.go Show resolved Hide resolved
server/coordinator.go Outdated Show resolved Hide resolved
server/schedule/plugin_interface.go Outdated Show resolved Hide resolved
plugin/evict_leader/Makefile Outdated Show resolved Hide resolved
server/handler.go Outdated Show resolved Hide resolved
server/handler.go Outdated Show resolved Hide resolved
server/handler.go Outdated Show resolved Hide resolved
server/handler.go Outdated Show resolved Hide resolved
lhy1024
lhy1024 reviewed Oct 14, 2019
View reviewed changes
plugin/evict_leader/base_scheduler.go Outdated Show resolved Hide resolved
plugin/evict_leader/base_scheduler.go Outdated Show resolved Hide resolved
plugin/evict_leader/evict_leader.go Outdated Show resolved Hide resolved
server/api/plugin.go Outdated Show resolved Hide resolved
plugin/grant_leader/grant_leader.go Outdated Show resolved Hide resolved
server/schedule/plugin_interface.go Outdated Show resolved Hide resolved
server/schedule/plugin_interface.go Outdated Show resolved Hide resolved
server/schedule/plugin_interface.go Outdated Show resolved Hide resolved
tools/pd-ctl/pdctl/command/plugin_command.go Show resolved Hide resolved
server/coordinator.go Outdated Show resolved Hide resolved
CheneyDing and others added 6 commits October 14, 2019 22:00
@CheneyDing @lhy1024
Update plugin/evict_leader/base_scheduler.go
87a1f66 
Co-Authored-By: lhy1024 <admin@liudos.us>
@CheneyDing @lhy1024
Update server/api/plugin.go
fdbf749 
Co-Authored-By: lhy1024 <admin@liudos.us>
@CheneyDing @lhy1024
Update server/schedule/plugin_interface.go
229df0a 
Co-Authored-By: lhy1024 <admin@liudos.us>
@CheneyDing @lhy1024
Update server/schedule/plugin_interface.go
ebae046 
Co-Authored-By: lhy1024 <admin@liudos.us>
@CheneyDing
resolve some conversation
9838ece
@CheneyDing
resolve merge conflict
311658d
lhy1024
lhy1024 reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rest LGTM.

server/api/plugin.go Outdated Show resolved Hide resolved
plugin/scheduler_example/evict_leader/base_scheduler.go Outdated Show resolved Hide resolved
plugin/scheduler_example/grant_leader/grant_leader.go Outdated Show resolved Hide resolved
plugin/scheduler_example/grant_leader/grant_leader.go Outdated Show resolved Hide resolved
server/coordinator.go Outdated Show resolved Hide resolved
server/coordinator.go Outdated Show resolved Hide resolved
@nolouch nolouch requested a review from disksing October 16, 2019 03:48
lhy1024
lhy1024 reviewed Oct 21, 2019
View reviewed changes
plugin/scheduler_example/evict_leader/base_scheduler.go Outdated Show resolved Hide resolved
plugin/scheduler_example/evict_leader/base_scheduler.go Outdated Show resolved Hide resolved
plugin/scheduler_example/evict_leader/base_scheduler.go Outdated Show resolved Hide resolved
plugin/scheduler_example/evict_leader/base_scheduler.go Outdated Show resolved Hide resolved
plugin/scheduler_example/evict_leader/evict_leader.go Outdated Show resolved Hide resolved
plugin/scheduler_example/grant_leader/grant_leader.go Outdated Show resolved Hide resolved
plugin/scheduler_example/grant_leader/grant_leader.go Outdated Show resolved Hide resolved
plugin/scheduler_example/grant_leader/grant_leader.go Outdated Show resolved Hide resolved
server/api/plugin.go Outdated Show resolved Hide resolved
tools/pd-ctl/pdctl/command/plugin_command.go Outdated Show resolved Hide resolved
rleungx
rleungx reviewed Oct 22, 2019
View reviewed changes
server/api/plugin.go Outdated Show resolved Hide resolved
tools/pd-ctl/pdctl/command/plugin_command.go Outdated Show resolved Hide resolved
@lhy1024
Copy link
Contributor

lhy1024 commented Oct 23, 2019

would you like to address the problem that ci reported?

@nolouch
Copy link
Contributor

nolouch commented Dec 4, 2019 •
edited
Loading

I will help to add an integration test after this PR. PTAL @rleungx @lhy1024

rleungx
rleungx reviewed Dec 4, 2019
View reviewed changes
server/schedule/plugin_interface.go Outdated Show resolved Hide resolved
server/api/plugin.go Outdated Show resolved Hide resolved
server/api/plugin.go Outdated Show resolved Hide resolved
server/handler.go Outdated Show resolved Hide resolved
server/coordinator.go Outdated Show resolved Hide resolved
server/coordinator.go Outdated Show resolved Hide resolved
CheneyDing and others added 6 commits December 4, 2019 20:09
@CheneyDing
Merge remote-tracking branch 'upstream/master' into plug-sche
a2e42dd
@CheneyDing @rleungx
Update server/api/plugin.go
4eb027b 
Co-Authored-By: Ryan Leung <rleungx@gmail.com>
@CheneyDing @rleungx
Update server/api/plugin.go
252889d 
Co-Authored-By: Ryan Leung <rleungx@gmail.com>
@CheneyDing @rleungx
Update server/handler.go
c0d446f 
Co-Authored-By: Ryan Leung <rleungx@gmail.com>
@CheneyDing
resolve conflict
0d1a45c
@CheneyDing
modify coordinator
abdd00b
@CheneyDing @rleungx
Update server/schedule/plugin_interface.go
3abccb6 
Co-Authored-By: Ryan Leung <rleungx@gmail.com>
rleungx
rleungx reviewed Dec 11, 2019
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

server/cluster/coordinator.go Show resolved Hide resolved
shafreeck
shafreeck reviewed Dec 11, 2019
View reviewed changes
server/api/plugin.go Outdated Show resolved Hide resolved
server/schedule/plugin_interface.go Outdated Show resolved Hide resolved
server/schedule/plugin_interface.go Outdated Show resolved Hide resolved
tools/pd-ctl/pdctl/command/plugin_command.go Outdated Show resolved Hide resolved
@rleungx
Copy link
Member

rleungx commented Dec 17, 2019

PTAL @shafreeck

@nolouch
Copy link
Contributor

nolouch commented Dec 18, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit 3583afd into tikv:master Dec 18, 2019
Huster-ljw pushed a commit to Huster-ljw/pd that referenced this pull request Dec 18, 2019
@CheneyDing @Huster-ljw
proposal: pluggable PD scheduler (tikv#1799)
6699b3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafreeck shafreeck shafreeck left review comments

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 lhy1024 left review comments

@rleungx rleungx rleungx approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
component/schedule Scheduling logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
v4.0.0-beta
Development

Successfully merging this pull request may close these issues.
7 participants
@CheneyDing @lhy1024 @rleungx @codecov-io @nolouch @sre-bot @shafreeck